This time 10 years ago, much of the political commentariat, both Democratic and Republican, was having a grand old time making fun of Donald Trump.